Comments on: JavaScript URI class

By: Pontus

Pontus — Wed, 03 Feb 2010 18:39:19 +0000

Thanks for your feedback. I’ve implemented the the changes and found a bug in the original regexp which made it fail if no path was in the URI, e.g the regexp would fail on http://poppa.se and alike.

But that’s also fixed (I hope)!

By: Pierre Setteskog

Pierre Setteskog — Tue, 02 Feb 2010 10:46:10 +0000

encodeURIComponent and decodeURIComponent works bether than unescape/escape

and if you to this change you can also delete params from querystring by assign them to null

queryString: function() {
var tmp = [];
for (var name in this.variables) {
if (this.variables[name] != null) {
tmp.push(encodeURIComponent(name) + “=” + encodeURIComponent(this.variables[name]));
}
}
return tmp.length && tmp.join(”&”) || null;
},

By: Pierre Setteskog

Pierre Setteskog — Tue, 02 Feb 2010 10:32:30 +0000

Thank you wery usefull class!

var re = new RegExp(”(?:([-+a-zA-Z0-9]+)://” + // Scheme
“((.[^:]*):?(.*)?@)?” + // Userinfo
“(.[^:/]*)” + // Host
“:?([0-9]{1,6})?)?” + // Port
“(/.[^?#]*)” + // Path
“[?]?(.[^#]*)?” + // Query
“#?(.*)?”); // Fragment

will make the class accept site relative paths /sdsds?p=1